FINERACT-1185: Add anniversary interest posting period types#5761
FINERACT-1185: Add anniversary interest posting period types#5761SamaSVM wants to merge 1 commit intoapache:developfrom
Conversation
SamaSVM
force-pushed
the
FINERACT-1185/anniversary-interest-posting
branch
3 times, most recently
from
d2e1c89 to
2081a59
Compare
| periodEndDate = periodEndDate.with(TemporalAdjusters.lastDayOfMonth()); | ||
| break; | ||
| case ANNIVERSARY_MONTHLY: | ||
| periodEndDate = adjustToAnniversaryDay(periodStartDate.plusMonths(1), anniversaryDayOfMonth).minusDays(1); |
There was a problem hiding this comment.
minusDays(1) seems a hack to circumvent:
// interest posting always occurs on next day after the period end date.
periodEndDate = periodEndDate.plusDays(1);
There was a problem hiding this comment.
Dont mark it as resolved without any answer, please...
|
@bharathc27 FYI |
|
@SamaSVM Can you please make sure you are updating the Fineract JIRA story and the documentation in |
SamaSVM
force-pushed
the
FINERACT-1185/anniversary-interest-posting
branch
2 times, most recently
from
f025c53 to
8e6bb4f
Compare
|
@SamaSVM Please rebase this PR. |
SamaSVM
force-pushed
the
FINERACT-1185/anniversary-interest-posting
branch
from
8e6bb4f to
05a165e
Compare
| // produce period end date on current day | ||
| periodEndDate = periodStartDate; | ||
| // interest posting occurs on the next day after current day | ||
| periodEndDate = periodStartDate.plusDays(1); |
There was a problem hiding this comment.
These changes looks quite breaking ones... you are effectively shifting all period end date by 1 day. Why??
There was a problem hiding this comment.
I’ve left this logic unchanged for all non-ANNIVERSARY period types. I can try removing the plusDays(1) for the old types, but I’m not confident about the impact this might have on the rest of the logic.
Earlier we simply had the following at the end:
periodEndDate = periodEndDate.plusDays(1);
return periodEndDate;
There was a problem hiding this comment.
hm... i see.. i might need to understand this part of the logic more
3 participants
Description
Added four new SavingsPostingInterestPeriodType values that post interest on the same day of the month as the account opening date (the "anniversary" date).
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.